cleanup qemu/memory.c
This commit is contained in:
286
qemu/memory.c
286
qemu/memory.c
@ -92,7 +92,6 @@ void memory_unmap(struct uc_struct *uc, MemoryRegion *mr)
|
||||
obj = OBJECT(mr);
|
||||
obj->ref = 1;
|
||||
obj->free = g_free;
|
||||
g_free(mr->ioeventfds);
|
||||
g_free((char *)mr->name);
|
||||
mr->name = NULL;
|
||||
object_property_del_child(mr->uc, qdev_get_machine(mr->uc), obj, &error_abort);
|
||||
@ -115,7 +114,6 @@ int memory_free(struct uc_struct *uc)
|
||||
obj = OBJECT(mr);
|
||||
obj->ref = 1;
|
||||
obj->free = g_free;
|
||||
g_free(mr->ioeventfds);
|
||||
object_property_del_child(mr->uc, qdev_get_machine(mr->uc), obj, &error_abort);
|
||||
}
|
||||
|
||||
@ -152,12 +150,6 @@ static Int128 addrrange_end(AddrRange r)
|
||||
return int128_add(r.start, r.size);
|
||||
}
|
||||
|
||||
static AddrRange addrrange_shift(AddrRange range, Int128 delta)
|
||||
{
|
||||
int128_addto(&range.start, delta);
|
||||
return range;
|
||||
}
|
||||
|
||||
static bool addrrange_contains(AddrRange range, Int128 addr)
|
||||
{
|
||||
return int128_ge(addr, range.start)
|
||||
@ -249,55 +241,6 @@ static bool memory_listener_match(MemoryListener *listener,
|
||||
.readonly = (fr)->readonly, \
|
||||
}))
|
||||
|
||||
struct CoalescedMemoryRange {
|
||||
AddrRange addr;
|
||||
QTAILQ_ENTRY(CoalescedMemoryRange) link;
|
||||
};
|
||||
|
||||
struct MemoryRegionIoeventfd {
|
||||
AddrRange addr;
|
||||
bool match_data;
|
||||
uint64_t data;
|
||||
EventNotifier *e;
|
||||
};
|
||||
|
||||
static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a,
|
||||
MemoryRegionIoeventfd b)
|
||||
{
|
||||
if (int128_lt(a.addr.start, b.addr.start)) {
|
||||
return true;
|
||||
} else if (int128_gt(a.addr.start, b.addr.start)) {
|
||||
return false;
|
||||
} else if (int128_lt(a.addr.size, b.addr.size)) {
|
||||
return true;
|
||||
} else if (int128_gt(a.addr.size, b.addr.size)) {
|
||||
return false;
|
||||
} else if (a.match_data < b.match_data) {
|
||||
return true;
|
||||
} else if (a.match_data > b.match_data) {
|
||||
return false;
|
||||
} else if (a.match_data) {
|
||||
if (a.data < b.data) {
|
||||
return true;
|
||||
} else if (a.data > b.data) {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
if (a.e < b.e) {
|
||||
return true;
|
||||
} else if (a.e > b.e) {
|
||||
return false;
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
static bool memory_region_ioeventfd_equal(MemoryRegionIoeventfd a,
|
||||
MemoryRegionIoeventfd b)
|
||||
{
|
||||
return !memory_region_ioeventfd_before(a, b)
|
||||
&& !memory_region_ioeventfd_before(b, a);
|
||||
}
|
||||
|
||||
typedef struct FlatRange FlatRange;
|
||||
typedef struct FlatView FlatView;
|
||||
|
||||
@ -664,56 +607,6 @@ static FlatView *generate_memory_topology(MemoryRegion *mr)
|
||||
return view;
|
||||
}
|
||||
|
||||
static void address_space_add_del_ioeventfds(AddressSpace *as,
|
||||
MemoryRegionIoeventfd *fds_new,
|
||||
unsigned fds_new_nb,
|
||||
MemoryRegionIoeventfd *fds_old,
|
||||
unsigned fds_old_nb)
|
||||
{
|
||||
unsigned iold, inew;
|
||||
MemoryRegionIoeventfd *fd;
|
||||
MemoryRegionSection section;
|
||||
struct uc_struct *uc = as->uc;
|
||||
|
||||
/* Generate a symmetric difference of the old and new fd sets, adding
|
||||
* and deleting as necessary.
|
||||
*/
|
||||
|
||||
iold = inew = 0;
|
||||
while (iold < fds_old_nb || inew < fds_new_nb) {
|
||||
if (iold < fds_old_nb
|
||||
&& (inew == fds_new_nb
|
||||
|| memory_region_ioeventfd_before(fds_old[iold],
|
||||
fds_new[inew]))) {
|
||||
fd = &fds_old[iold];
|
||||
section = (MemoryRegionSection) {
|
||||
.address_space = as,
|
||||
.offset_within_address_space = int128_get64(fd->addr.start),
|
||||
.size = fd->addr.size,
|
||||
};
|
||||
MEMORY_LISTENER_CALL(eventfd_del, Forward, §ion,
|
||||
fd->match_data, fd->data, fd->e);
|
||||
++iold;
|
||||
} else if (inew < fds_new_nb
|
||||
&& (iold == fds_old_nb
|
||||
|| memory_region_ioeventfd_before(fds_new[inew],
|
||||
fds_old[iold]))) {
|
||||
fd = &fds_new[inew];
|
||||
section = (MemoryRegionSection) {
|
||||
.address_space = as,
|
||||
.offset_within_address_space = int128_get64(fd->addr.start),
|
||||
.size = fd->addr.size,
|
||||
};
|
||||
MEMORY_LISTENER_CALL(eventfd_add, Reverse, §ion,
|
||||
fd->match_data, fd->data, fd->e);
|
||||
++inew;
|
||||
} else {
|
||||
++iold;
|
||||
++inew;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
static FlatView *address_space_get_flatview(AddressSpace *as)
|
||||
{
|
||||
FlatView *view;
|
||||
@ -723,40 +616,6 @@ static FlatView *address_space_get_flatview(AddressSpace *as)
|
||||
return view;
|
||||
}
|
||||
|
||||
static void address_space_update_ioeventfds(AddressSpace *as)
|
||||
{
|
||||
FlatView *view;
|
||||
FlatRange *fr;
|
||||
unsigned ioeventfd_nb = 0;
|
||||
MemoryRegionIoeventfd *ioeventfds = NULL;
|
||||
AddrRange tmp;
|
||||
unsigned i;
|
||||
|
||||
view = address_space_get_flatview(as);
|
||||
FOR_EACH_FLAT_RANGE(fr, view) {
|
||||
for (i = 0; i < fr->mr->ioeventfd_nb; ++i) {
|
||||
tmp = addrrange_shift(fr->mr->ioeventfds[i].addr,
|
||||
int128_sub(fr->addr.start,
|
||||
int128_make64(fr->offset_in_region)));
|
||||
if (addrrange_intersects(fr->addr, tmp)) {
|
||||
++ioeventfd_nb;
|
||||
ioeventfds = g_realloc(ioeventfds,
|
||||
ioeventfd_nb * sizeof(*ioeventfds));
|
||||
ioeventfds[ioeventfd_nb-1] = fr->mr->ioeventfds[i];
|
||||
ioeventfds[ioeventfd_nb-1].addr = tmp;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
address_space_add_del_ioeventfds(as, ioeventfds, ioeventfd_nb,
|
||||
as->ioeventfds, as->ioeventfd_nb);
|
||||
|
||||
g_free(as->ioeventfds);
|
||||
as->ioeventfds = ioeventfds;
|
||||
as->ioeventfd_nb = ioeventfd_nb;
|
||||
flatview_unref(view);
|
||||
}
|
||||
|
||||
static void address_space_update_topology_pass(AddressSpace *as,
|
||||
const FlatView *old_view,
|
||||
const FlatView *new_view,
|
||||
@ -839,8 +698,6 @@ static void address_space_update_topology(AddressSpace *as)
|
||||
* counting is necessary.
|
||||
*/
|
||||
flatview_unref(old_view);
|
||||
|
||||
address_space_update_ioeventfds(as);
|
||||
}
|
||||
|
||||
void memory_region_transaction_begin(struct uc_struct *uc)
|
||||
@ -851,7 +708,6 @@ void memory_region_transaction_begin(struct uc_struct *uc)
|
||||
static void memory_region_clear_pending(struct uc_struct *uc)
|
||||
{
|
||||
uc->memory_region_update_pending = false;
|
||||
uc->ioeventfd_update_pending = false;
|
||||
}
|
||||
|
||||
void memory_region_transaction_commit(struct uc_struct *uc)
|
||||
@ -869,10 +725,6 @@ void memory_region_transaction_commit(struct uc_struct *uc)
|
||||
}
|
||||
|
||||
MEMORY_LISTENER_CALL_GLOBAL(commit, Forward);
|
||||
} else if (uc->ioeventfd_update_pending) {
|
||||
QTAILQ_FOREACH(as, &uc->address_spaces, address_spaces_link) {
|
||||
address_space_update_ioeventfds(as);
|
||||
}
|
||||
}
|
||||
memory_region_clear_pending(uc);
|
||||
}
|
||||
@ -1026,7 +878,6 @@ static void memory_region_initfn(struct uc_struct *uc, Object *obj, void *opaque
|
||||
mr->romd_mode = true;
|
||||
mr->destructor = memory_region_destructor_none;
|
||||
QTAILQ_INIT(&mr->subregions);
|
||||
QTAILQ_INIT(&mr->coalesced);
|
||||
|
||||
op = object_property_add(OBJECT(mr), "container",
|
||||
"link<" TYPE_MEMORY_REGION ">",
|
||||
@ -1263,9 +1114,7 @@ static void memory_region_finalize(struct uc_struct *uc, Object *obj, void *opaq
|
||||
assert(QTAILQ_EMPTY(&mr->subregions));
|
||||
// assert(memory_region_transaction_depth == 0);
|
||||
mr->destructor(mr);
|
||||
memory_region_clear_coalescing(mr);
|
||||
g_free((char *)mr->name);
|
||||
g_free(mr->ioeventfds);
|
||||
}
|
||||
|
||||
void memory_region_ref(MemoryRegion *mr)
|
||||
@ -1388,138 +1237,6 @@ void *memory_region_get_ram_ptr(MemoryRegion *mr)
|
||||
return qemu_get_ram_ptr(mr->uc, mr->ram_addr & TARGET_PAGE_MASK);
|
||||
}
|
||||
|
||||
static void memory_region_update_coalesced_range_as(MemoryRegion *mr, AddressSpace *as)
|
||||
{
|
||||
FlatView *view;
|
||||
FlatRange *fr;
|
||||
CoalescedMemoryRange *cmr;
|
||||
AddrRange tmp;
|
||||
MemoryRegionSection section;
|
||||
struct uc_struct *uc = mr->uc;
|
||||
|
||||
view = address_space_get_flatview(as);
|
||||
FOR_EACH_FLAT_RANGE(fr, view) {
|
||||
if (fr->mr == mr) {
|
||||
section = (MemoryRegionSection) {
|
||||
.address_space = as,
|
||||
.offset_within_address_space = int128_get64(fr->addr.start),
|
||||
.size = fr->addr.size,
|
||||
};
|
||||
|
||||
MEMORY_LISTENER_CALL(coalesced_mmio_del, Reverse, §ion,
|
||||
int128_get64(fr->addr.start),
|
||||
int128_get64(fr->addr.size));
|
||||
QTAILQ_FOREACH(cmr, &mr->coalesced, link) {
|
||||
tmp = addrrange_shift(cmr->addr,
|
||||
int128_sub(fr->addr.start,
|
||||
int128_make64(fr->offset_in_region)));
|
||||
if (!addrrange_intersects(tmp, fr->addr)) {
|
||||
continue;
|
||||
}
|
||||
tmp = addrrange_intersection(tmp, fr->addr);
|
||||
MEMORY_LISTENER_CALL(coalesced_mmio_add, Forward, §ion,
|
||||
int128_get64(tmp.start),
|
||||
int128_get64(tmp.size));
|
||||
}
|
||||
}
|
||||
}
|
||||
flatview_unref(view);
|
||||
}
|
||||
|
||||
static void memory_region_update_coalesced_range(MemoryRegion *mr)
|
||||
{
|
||||
AddressSpace *as;
|
||||
|
||||
QTAILQ_FOREACH(as, &mr->uc->address_spaces, address_spaces_link) {
|
||||
memory_region_update_coalesced_range_as(mr, as);
|
||||
}
|
||||
}
|
||||
|
||||
void memory_region_clear_coalescing(MemoryRegion *mr)
|
||||
{
|
||||
CoalescedMemoryRange *cmr;
|
||||
bool updated = false;
|
||||
|
||||
mr->flush_coalesced_mmio = false;
|
||||
|
||||
while (!QTAILQ_EMPTY(&mr->coalesced)) {
|
||||
cmr = QTAILQ_FIRST(&mr->coalesced);
|
||||
QTAILQ_REMOVE(&mr->coalesced, cmr, link);
|
||||
g_free(cmr);
|
||||
updated = true;
|
||||
}
|
||||
|
||||
if (updated) {
|
||||
memory_region_update_coalesced_range(mr);
|
||||
}
|
||||
}
|
||||
|
||||
void memory_region_add_eventfd(MemoryRegion *mr,
|
||||
hwaddr addr,
|
||||
unsigned size,
|
||||
bool match_data,
|
||||
uint64_t data,
|
||||
EventNotifier *e)
|
||||
{
|
||||
MemoryRegionIoeventfd mrfd = {
|
||||
.addr.start = int128_make64(addr),
|
||||
.addr.size = int128_make64(size),
|
||||
.match_data = match_data,
|
||||
.data = data,
|
||||
.e = e,
|
||||
};
|
||||
unsigned i;
|
||||
|
||||
adjust_endianness(mr, &mrfd.data, size);
|
||||
memory_region_transaction_begin(mr->uc);
|
||||
for (i = 0; i < mr->ioeventfd_nb; ++i) {
|
||||
if (memory_region_ioeventfd_before(mrfd, mr->ioeventfds[i])) {
|
||||
break;
|
||||
}
|
||||
}
|
||||
++mr->ioeventfd_nb;
|
||||
mr->ioeventfds = g_realloc(mr->ioeventfds,
|
||||
sizeof(*mr->ioeventfds) * mr->ioeventfd_nb);
|
||||
memmove(&mr->ioeventfds[i+1], &mr->ioeventfds[i],
|
||||
sizeof(*mr->ioeventfds) * (mr->ioeventfd_nb-1 - i));
|
||||
mr->ioeventfds[i] = mrfd;
|
||||
mr->uc->ioeventfd_update_pending |= mr->enabled;
|
||||
memory_region_transaction_commit(mr->uc);
|
||||
}
|
||||
|
||||
void memory_region_del_eventfd(MemoryRegion *mr,
|
||||
hwaddr addr,
|
||||
unsigned size,
|
||||
bool match_data,
|
||||
uint64_t data,
|
||||
EventNotifier *e)
|
||||
{
|
||||
MemoryRegionIoeventfd mrfd = {
|
||||
.addr.start = int128_make64(addr),
|
||||
.addr.size = int128_make64(size),
|
||||
.match_data = match_data,
|
||||
.data = data,
|
||||
.e = e,
|
||||
};
|
||||
unsigned i;
|
||||
|
||||
adjust_endianness(mr, &mrfd.data, size);
|
||||
memory_region_transaction_begin(mr->uc);
|
||||
for (i = 0; i < mr->ioeventfd_nb; ++i) {
|
||||
if (memory_region_ioeventfd_equal(mrfd, mr->ioeventfds[i])) {
|
||||
break;
|
||||
}
|
||||
}
|
||||
assert(i != mr->ioeventfd_nb);
|
||||
memmove(&mr->ioeventfds[i], &mr->ioeventfds[i+1],
|
||||
sizeof(*mr->ioeventfds) * (mr->ioeventfd_nb - (i+1)));
|
||||
--mr->ioeventfd_nb;
|
||||
mr->ioeventfds = g_realloc(mr->ioeventfds,
|
||||
sizeof(*mr->ioeventfds)*mr->ioeventfd_nb + 1);
|
||||
mr->uc->ioeventfd_update_pending |= mr->enabled;
|
||||
memory_region_transaction_commit(mr->uc);
|
||||
}
|
||||
|
||||
static void memory_region_update_container_subregions(MemoryRegion *subregion)
|
||||
{
|
||||
hwaddr offset = subregion->addr;
|
||||
@ -1818,8 +1535,6 @@ void address_space_init(struct uc_struct *uc, AddressSpace *as, MemoryRegion *ro
|
||||
as->root = root;
|
||||
as->current_map = g_new(FlatView, 1);
|
||||
flatview_init(as->current_map);
|
||||
as->ioeventfd_nb = 0;
|
||||
as->ioeventfds = NULL;
|
||||
QTAILQ_INSERT_TAIL(&uc->address_spaces, as, address_spaces_link);
|
||||
as->name = g_strdup(name ? name : "anonymous");
|
||||
address_space_init_dispatch(as);
|
||||
@ -1847,7 +1562,6 @@ void address_space_destroy(AddressSpace *as)
|
||||
|
||||
flatview_unref(as->current_map);
|
||||
g_free(as->name);
|
||||
g_free(as->ioeventfds);
|
||||
}
|
||||
|
||||
bool io_mem_read(MemoryRegion *mr, hwaddr addr, uint64_t *pval, unsigned size)
|
||||
|
Reference in New Issue
Block a user